Merged
Conversation
|
|
hutuxian
force-pushed
the
pipeline
branch
5 times, most recently
from
db9ed40 to
112eb21
Compare
paddle/fluid/framework/data_feed.cc
Outdated
Member
There was a problem hiding this comment.
I've fixed some bugs of dense tensor Resize, maybe you need to adapt the changes later.
paddle/fluid/framework/data_feed.cc
Outdated
Member
There was a problem hiding this comment.
I fixed some bugs here, maybe you can merge from develop.
paddle/fluid/framework/data_feed.h
Outdated
Member
There was a problem hiding this comment.
why do you have to add reserved_size?
paddle/fluid/framework/executor.cc
Outdated
Member
There was a problem hiding this comment.
great, thanks for your fix.
paddle/fluid/framework/trainer.h
Outdated
Member
There was a problem hiding this comment.
workers_ here should be documented more clearly.
paddle/fluid/framework/trainer.h
Outdated
Member
There was a problem hiding this comment.
scope_queues_ should be documented clearly, this is a very important data structure in your design.
python/paddle/fluid/executor.py
Outdated
Member
There was a problem hiding this comment.
not sure whether this matches the newest API, please check and merge diff.
hutuxian
force-pushed
the
pipeline
branch
2 times, most recently
from
0b4e590 to
848c376
Compare
hutuxian
force-pushed
the
pipeline
branch
7 times, most recently
from
6821ce2 to
379560b
Compare
hutuxian
force-pushed
the
pipeline
branch
2 times, most recently
from
ca7276d to
aa6c2c9
Compare
added 5 commits
June 10, 2019 19:48
- cpp: pipeline_trainer & section_worker - python: PipelineOptimizer Add a new datafeed type: PrivateInstantDataFeed test=develop
test=develop
add start_cpu_core_id and param_need_sync in proto update the stream in sync functor test=develop
model is gnn test=develop
hutuxian
force-pushed
the
pipeline
branch
3 times, most recently
from
de105c9 to
3a997b1
Compare
add API.spec test=develop
gavin1332
approved these changes
Jun 11, 2019
Collaborator
gavin1332
left a comment
gavin1332
left a comment
There was a problem hiding this comment.
code review have be done in the offline
hutuxian
added a commit
to hutuxian/Paddle
that referenced
this pull request
Jun 11, 2019
test=release/1.5 Add Pipeline Concurrency Train Mode: - Cpp: pipeline_trainer & section_worker - Python: PipelineOptimizer - Add a new data_feed type: PrivateInstantDataFeed - Add a test demo of pipeline trainer and the test model is gnn - Do not support win32 now
hutuxian
added a commit
that referenced
this pull request
Jun 17, 2019
cherry-pick for (#17402) Add Pipeline Concurrency Train Mode: - Cpp: pipeline_trainer & section_worker - Python: PipelineOptimizer - Add a new data_feed type: PrivateInstantDataFeed - Add a test demo of pipeline trainer and the test model is gnn - Do not support win32 now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the pipeline concurrency function