Skip to content

Add conditional compile for gru opt#17368

Merged
zhaoyuchen2018 merged 6 commits intoPaddlePaddle:developfrom
zhaoyuchen2018:improveop
May 16, 2019
Merged

Add conditional compile for gru opt#17368
zhaoyuchen2018 merged 6 commits intoPaddlePaddle:developfrom
zhaoyuchen2018:improveop

Conversation

@zhaoyuchen2018
Copy link
Contributor

@zhaoyuchen2018 zhaoyuchen2018 commented May 13, 2019

Not enable gru opt if compute ability < 70

Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

origin_mode);

return;
if (context.GetComputeCapability() >= 70) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not use magic number 70, you can address in next PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@zhaoyuchen2018 zhaoyuchen2018 merged commit b02f2af into PaddlePaddle:develop May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants