Fix ParallelExecutor bug#17204
Merged
chengduoZH merged 1 commit intoPaddlePaddle:developfrom May 6, 2019
Merged
Conversation
chengduoZH
force-pushed
the
update_ParallelExecutor
branch
2 times, most recently
from
e917155 to
89dd64f
Compare
test=develop
chengduoZH
force-pushed
the
update_ParallelExecutor
branch
from
89dd64f to
3aa5731
Compare
chengduoZH
commented
May 7, 2019
| if build_strategy is None: | ||
| build_strategy = BuildStrategy() | ||
| build_strategy.num_trainers = num_trainers | ||
| build_strategy.trainer_id = trainer_id |
Contributor
Author
There was a problem hiding this comment.
The trainer_id and num_trainers of build_strategy should not be overwritten by the passed trainer_id and num_trainers of ParallelExecutor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trainer_idandnum_trainersofbuild_strategyshould not be overwritten by the passedtrainer_idandnum_trainersofParallelExecutor.