Skip to content

fix python3 run_time_error in uniform_random. test=develop#17152

Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom
fc-liu:develop
Apr 29, 2019
Merged

fix python3 run_time_error in uniform_random. test=develop#17152
luotao1 merged 1 commit intoPaddlePaddle:developfrom
fc-liu:develop

Conversation

@fc-liu
Copy link
Contributor

@fc-liu fc-liu commented Apr 29, 2019

fix runtimeerror : dictionary changed size during iteration when calling uniform_random in python3+
related #17086

fix runtimeerror : dictionary changed size during iteration when calling uniform_random in python3+
@luotao1 luotao1 requested a review from junjun315 April 29, 2019 03:51
@luotao1 luotao1 changed the title fix run_time_error in uniform_random. test=develop fix python3 run_time_error in uniform_random. test=develop Apr 29, 2019
Copy link
Contributor

@junjun315 junjun315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Apr 29, 2019

python35 has a random fail unit-test, I rerun it and please wait.

@luotao1 luotao1 merged commit 626922d into PaddlePaddle:develop Apr 29, 2019
@luotao1
Copy link
Contributor

luotao1 commented Apr 29, 2019

$ grep -rn "locals_var = locals().keys()" python/paddle/fluid/layers/ops.py
python/paddle/fluid/layers/ops.py:105:    locals_var = locals().keys()
python/paddle/fluid/layers/ops.py:127:    locals_var = locals().keys()
python/paddle/fluid/layers/ops.py:149:    locals_var = locals().keys()

Could you update below three lines in a new PR? Thanks very much for your contribution!
@Lfc1993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants