Reformat fleet API#17135
Merged
seiriosPlus merged 11 commits intoPaddlePaddle:developfrom May 9, 2019
Merged
Conversation
seiriosPlus
requested review from
guru4elephant and
xjqbest
and removed request for
guru4elephant and
xjqbest
seiriosPlus
requested review from
guru4elephant and
xjqbest
and removed request for
guru4elephant
xjqbest
reviewed
May 6, 2019
| scopes(Scope|list): a Scope or a list of Scopes, default None. | ||
| executor(Executor): The executor to run for init server. | ||
| programs(Program|None): The program that need to run. | ||
| """ |
Contributor
There was a problem hiding this comment.
what if a user uses more than one scope , each for a specific main_program.
in this case, init_worker no longer supports this.
Contributor
There was a problem hiding this comment.
oh，these scopes are passed to fleet in minimize，ignore the above.
| from enum import Enum | ||
|
|
||
| from paddle.fluid.optimizer import SGD | ||
| from paddle.fluid.executor import Executor |
Member
There was a problem hiding this comment.
why do you import Executor here?
Collaborator
Author
There was a problem hiding this comment.
for value check, isinstance of
guru4elephant
approved these changes
May 8, 2019
Member
guru4elephant
left a comment
guru4elephant
left a comment
There was a problem hiding this comment.
LGTM. You need to update official document with replicable examples and API docs.
fuyinno4
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like title