Skip to content

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Mar 28, 2017

考虑 #1608 ,为了使seqlastin, average, max三个layer具有一致性,方便后续添加stride参数。将average的backward封装成sequenceAvgBackward函数。

  • 补充gpu下sequenceAvgBackward函数的实现。
  • 在test_matrixCompare下,补充sequenceAvgBackward函数的单测。

@luotao1 luotao1 requested a review from qingqing01 March 28, 2017 09:32
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

另外,如果后面改成function,可能还需要做一次改动~

@luotao1
Copy link
Contributor Author

luotao1 commented Mar 29, 2017

后面改成function的话,可以再改动。这里改动,是为了统一加stride参数。

@luotao1 luotao1 merged commit b1f16d2 into PaddlePaddle:develop Mar 29, 2017
@luotao1 luotao1 deleted the avg branch March 29, 2017 05:13
zhangyuqin1998 pushed a commit to zhangyuqin1998/Paddle that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants