Skip to content

1. move the API check into CPU process#17110

Merged
wopeizl merged 2 commits intoPaddlePaddle:developfrom
wopeizl:adjust_api_check
Apr 29, 2019
Merged

1. move the API check into CPU process#17110
wopeizl merged 2 commits intoPaddlePaddle:developfrom
wopeizl:adjust_api_check

Conversation

@wopeizl
Copy link
Contributor

@wopeizl wopeizl commented Apr 26, 2019

  1. adjust the check order
    test=develop

wopeizl added 2 commits April 26, 2019 10:23
2. adjust the check order
test=develop
Copy link
Contributor

@junjun315 junjun315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build ${parallel_number}
assert_api_not_changed ${PYTHON_ABI:-""}
parallel_test
assert_api_spec_approvals
Copy link
Contributor

@junjun315 junjun315 Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cicheck not need assert_api_spec_approvals?!

挪到cpu build去了 那个快 这样可以节省ci时间

@wopeizl wopeizl merged commit 3acb363 into PaddlePaddle:develop Apr 29, 2019
assert_api_not_changed ${PYTHON_ABI:-""}
parallel_test
assert_api_spec_approvals
assert_api_not_changed ${PYTHON_ABI:-""}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert_api_not_changed 可以放在parallel_test前节省时间。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants