Use CudnnWorkspaceHandle in exhaustive search#17082
Merged
zhhsplendid merged 4 commits intoPaddlePaddle:developfrom Apr 28, 2019
Merged
Use CudnnWorkspaceHandle in exhaustive search#17082zhhsplendid merged 4 commits intoPaddlePaddle:developfrom
zhhsplendid merged 4 commits intoPaddlePaddle:developfrom
Conversation
test=develop
chengduoZH
reviewed
Apr 25, 2019
| } | ||
| holder_->RunFuncImpl(std::forward<Callback>(cudnn_func), | ||
| required_workspace_len); | ||
| holder_->ResetWorkspace(); |
Contributor
There was a problem hiding this comment.
The execution of CUDA code is async, so you should call cudaStreamSync before reset workspace.
Collaborator
There was a problem hiding this comment.
Maybe we should call this method RunFuncSync? Because this function may be only used when cudnn exhaustive searching, and cudnnFindConvolutionForwardAlgorithmEx is a synchronized method as described in here.
@zhhsplendid Please also add some comments on this method, something like: you have to guarantee that the function is host blocking.
Member
Author
There was a problem hiding this comment.
@chengduoZH Done. I added inside ResetWorkspace() to enforce users to call cudaStreamSynchronize.
@sneaxiy Done
test=develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test=develop