Fix the bug of test_conv2d_int8_mkldnn case which raised by improper parameter passing#17058
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Apr 24, 2019
guomingz:resolve_issue_17057
Merged
Fix the bug of test_conv2d_int8_mkldnn case which raised by improper parameter passing#17058luotao1 merged 2 commits intoPaddlePaddle:developfrom guomingz:resolve_issue_17057
luotao1 merged 2 commits intoPaddlePaddle:developfrom
guomingz:resolve_issue_17057
Conversation
Contributor
|
please make PR title easy to understand. |
Contributor
Author
Sorry ， i made the explanation on the issue description. |
Contributor
|
The issue title is easy to understand, you can make the PR title like issue title, not just copy. |
…parameter passing. test=develop
Contributor
Author
thanks for suggestion. If the description is ok, i'll update the commit later. |
Contributor
|
I think it's nice! |
Contributor
Author
Updated. Please help to add Intel Label |
Contributor
Author
|
hi @luotao1 the pre-ci had been passed, please help to review the PR. |
luotao1
changed the title
Contributor
Author
Thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #17057
Fixed the bug that fuse_relu/fuse_residual option couldn't be passed to class TestConv2dInt8Op.Fix the bug of test_conv2d_int8_mkldnn case which raised by improper parameter passing.
test=develop