Skip to content

update ngraph version#16990

Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom
baojun-nervana:ng_cmake
Apr 23, 2019
Merged

update ngraph version#16990
luotao1 merged 1 commit intoPaddlePaddle:developfrom
baojun-nervana:ng_cmake

Conversation

@baojun-nervana
Copy link
Contributor

to resolve ngraph test hanging issue on centos6 #15599
It was due to incompatible glibc on centos6

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2019

CLA assistant check
All committers have signed the CLA.

@tensor-tang
Copy link
Contributor

to resolve ngraph test hanging issue on centos6

Thanks @baojun-nervana , but seem #15599 has been solved #16447 , so what is the hanging issue?

@baojun-nervana
Copy link
Contributor Author

baojun-nervana commented Apr 22, 2019

@tensor-tang The hanging issue was reported by @luotao1, but I wasn't able to reproduce the issue before. Recently I was finally able to reproduce it with manylinux docker and resolve it.
@luotao1 's comment:
#15599 (comment)

@luotao1
Copy link
Contributor

luotao1 commented Apr 23, 2019

-- extern_ngraph configure command succeeded.  See also /Paddle/manylinux1_build/third_party/ngraph/src/extern_ngraph-stamp/extern_ngraph-configure-*.log
[ 42%] Performing build step for 'extern_ngraph'
Scanning dependencies of target ext_mkldnn
Scanning dependencies of target ext_json
Scanning dependencies of target ext_eigen
Scanning dependencies of target ext_gtest
[  0%] Creating directories for 'ext_mkldnn'
[  0%] Creating directories for 'ext_json'
[  0%] Creating directories for 'ext_eigen'
[  1%] Creating directories for 'ext_gtest'
[  1%] No download step for 'ext_mkldnn'
[  2%] Performing download step (git clone) for 'ext_json'
[  2%] Performing download step (git clone) for 'ext_eigen'
[  2%] Performing download step (git clone) for 'ext_gtest'
[  2%] No patch step for 'ext_mkldnn'
[  3%] No update step for 'ext_mkldnn'
Initialized empty Git repository in /Paddle/manylinux1_build/third_party/ngraph/src/extern_ngraph-build/json/src/ext_json/.git/
Initialized empty Git repository in /Paddle/manylinux1_build/third_party/ngraph/src/extern_ngraph-build/eigen/src/ext_eigen/.git/
Initialized empty Git repository in /Paddle/manylinux1_build/third_party/ngraph/src/extern_ngraph-build/gtest/src/ext_gtest/.git/
[  3%] No configure step for 'ext_mkldnn'
[  4%] No build step for 'ext_mkldnn'
[  5%] No install step for 'ext_mkldnn'
[  5%] Completed 'ext_mkldnn'
[  5%] Built target ext_mkldnn
Note: checking out 'release-1.8.1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 2fe3bd9... Merge pull request #1433 from dsacre/fix-clang-warnings
[  6%] No patch step for 'ext_gtest'
[  6%] No update step for 'ext_gtest'
[  6%] Performing configure step for 'ext_gtest'
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /opt/rh/devtoolset-2/root/usr/bin/cc
-- Check for working C compiler: /opt/rh/devtoolset-2/root/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /opt/rh/devtoolset-2/root/usr/bin/c++
-- Check for working CXX compiler: /opt/rh/devtoolset-2/root/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PythonInterp: /usr/bin/python (found version "2.6.6")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /Paddle/manylinux1_build/third_party/ngraph/src/extern_ngraph-build/gtest/build
[  6%] Performing build step for 'ext_gtest'
Scanning dependencies of target gtest
[ 12%] Building CXX object googlemock/gtest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 25%] Linking CXX static library libgtest.a
[ 25%] Built target gtest
Scanning dependencies of target gtest_main
Scanning dependencies of target gmock
[ 37%] Building CXX object googlemock/gtest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o
[ 50%] Building CXX object googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o
[ 62%] Linking CXX static library libgtest_main.a
[ 62%] Built target gtest_main
[ 75%] Linking CXX static library libgmock.a
[ 75%] Built target gmock
Scanning dependencies of target gmock_main
[ 87%] Building CXX object googlemock/CMakeFiles/gmock_main.dir/src/gmock_main.cc.o
[100%] Linking CXX static library libgmock_main.a
[100%] Built target gmock_main
[  6%] No install step for 'ext_gtest'
[  6%] Completed 'ext_gtest'
[  6%] Built target ext_gtest

Do we need ext_mkldnn, ext_json, ext_eigen and ext_gtest?
To make the third_party as small as possible

  • ext_mkldnn, ext_eigencould not be git clone again since we have already mkldnn.cmake and eigen.cmake?
  • ext_json, and ext_gtest could be removed since we don't need it?

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!I test the ctest -R test_mul_ngraph -V on manylinux image, it runs OK.

@luotao1 luotao1 merged commit 620b054 into PaddlePaddle:develop Apr 23, 2019
@luotao1
Copy link
Contributor

luotao1 commented Apr 23, 2019

@baojun-nervana baojun-nervana deleted the ng_cmake branch April 23, 2019 18:28
@baojun-nervana
Copy link
Contributor Author

@luotao1 ext_mkldnn is just a target name. We use paddle mkldnn. We need json for ngraph debug purpose to dump the graph. We can look into using shared eigen and removing gtest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants