fix overflow by int32 mul test=develop#16794
Merged
liupluswei merged 8 commits intoPaddlePaddle:developfrom Apr 17, 2019
Merged
fix overflow by int32 mul test=develop#16794liupluswei merged 8 commits intoPaddlePaddle:developfrom
liupluswei merged 8 commits intoPaddlePaddle:developfrom
Conversation
Contributor
|
Each commit should add |
liupluswei
reviewed
Apr 16, 2019
| PADDLE_ENFORCE_EQ(in->lod().size(), 1UL, | ||
| "Only support one level sequence now."); | ||
|
|
||
| const Tensor* padding_data = nullptr; |
Contributor
There was a problem hiding this comment.
I think modify the ContextProjectFunctor API will be cleaner, update the const Tensor& padding_data parameter to const Tensor padding_data*, and inside the API, if padding_trainable is true, PADDLE_ENFORCE_NOT_NULL(padding_data)
Contributor
Author
There was a problem hiding this comment.
Thanks，API has been modified from reference to point.
liupluswei
added a commit
that referenced
this pull request
Apr 17, 2019
* Security issue (#16774) * disable memory_optimize and inpalce strategy by default, test=develop * fix security issue http://newicafe.baidu.com:80/issue/PaddleSec-3/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-8/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-12/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-32/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-35/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-37/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-40/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-43/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-44/show?from=page http://newicafe.baidu.com:80/issue/PaddleSec-45/show?from=page test=develop * revert piece.cc, test=develop * adjust api.cc,test=develop * fix overflow by int32 mul test=develop (#16794) * fix overflow by int32 mul test=develop * fix reference nullptr * fix codestyle test=develop * modify to point in ContextProjectFunctor test=develop * modify to point in ContextProjectFunctor test=develop * modify . to -> test=develop * test=release/1.4 cherry-pick (#16783) (#16794) (#16774) fix security issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复int32相乘overflow的问题