Fix the order while sorting the operators#16756
Merged
luotao1 merged 3 commits intoPaddlePaddle:developfrom Apr 12, 2019
Merged
Fix the order while sorting the operators#16756luotao1 merged 3 commits intoPaddlePaddle:developfrom
luotao1 merged 3 commits intoPaddlePaddle:developfrom
Conversation
test=develop
This was referenced Apr 10, 2019
test=develop
Contributor
Author
|
start a review |
Contributor
|
LGTM |
Superjomn
reviewed
Apr 11, 2019
| namespace { | ||
| void SortHelper( | ||
| const std::map<ir::Node *, std::unordered_set<ir::Node *>> &adj_list, | ||
| const std::map<ir::Node *, std::vector<ir::Node *>, ir::NodeComp> &adj_list, |
Contributor
There was a problem hiding this comment.
try just change unordered_set to std::set ?
the set is a binary search tree and should work like a sorted vector in this scenario.
Contributor
Author
There was a problem hiding this comment.
Done, it should be OK. please wait CI's result.
Contributor
Author
There was a problem hiding this comment.
Just now all CI testing are passed. Please help us review it again.
test=develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As ISSUE#16688 description, it was found the order's random will result in the difference when do the compare item of unit test. Now to use set to replace unordered_set can be resolve this issue.
resolve #16688
resolve #16316
resolve #16473
resolve #16586