Merged
Conversation
sneaxiy
force-pushed
the
fix_allocator_bug2
branch
from
f5a9ae4 to
25a7221
Compare
sneaxiy
force-pushed
the
fix_allocator_bug2
branch
from
cdbec37 to
5dd5c43
Compare
sneaxiy
force-pushed
the
fix_allocator_bug2
branch
from
5dd5c43 to
d53b700
Compare
chengduoZH
reviewed
May 23, 2019
| Allocation(const Allocation& o) = delete; | ||
| Allocation& operator=(const Allocation& o) = delete; | ||
| Allocation(Allocation&& o) = delete; | ||
| Allocation& operator=(Allocation&& o) = delete; |
Contributor
There was a problem hiding this comment.
Why remove those methods?
Collaborator
Author
There was a problem hiding this comment.
Because Allocation should not be moved.
Collaborator
Author
There was a problem hiding this comment.
Because Allocation should not be moved. So I remove those methods generated by compiler.
chengduoZH
reviewed
May 23, 2019
Contributor
chengduoZH
left a comment
chengduoZH
left a comment
There was a problem hiding this comment.
Please add doc to explain the reason for adding InlinedVector in this PR.
Collaborator
Author
|
@chengduoZH I would add some doc of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous architecture of
Allocatorwould cause someAllocationcannot be released, saying potential memory leak. This PR fixes it.For more details of Allocator design, please refer to
paddle/fluid/memory/allocation/allocator.hin this PR.CE has passed. Please see here.