Skip to content

Fix the bug of the fast threaded executor#16514

Merged
chengduoZH merged 9 commits intoPaddlePaddle:developfrom
chengduoZH:speed/enable_experimental_executor
Apr 2, 2019
Merged

Fix the bug of the fast threaded executor#16514
chengduoZH merged 9 commits intoPaddlePaddle:developfrom
chengduoZH:speed/enable_experimental_executor

Conversation

@chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Mar 28, 2019

Fix the bug of the fast threaded executor. In some case, the fetch_op are ready at the beginning, so we should deal with the ready_fetch_ops.

chengduozh added 2 commits March 28, 2019 13:33
@chengduoZH chengduoZH force-pushed the speed/enable_experimental_executor branch from f4576c2 to 5aa27da Compare March 29, 2019 08:22
@chengduoZH chengduoZH force-pushed the speed/enable_experimental_executor branch from f8cfad4 to 84fce51 Compare April 2, 2019 01:47
@chengduoZH chengduoZH requested a review from Yancey0623 April 2, 2019 01:48
Copy link
Contributor

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chengduoZH chengduoZH changed the title Test ExperimentalExecutor Fix the bug of the fast threaded executor Apr 2, 2019
fetches.resize(fetch_tensors.size());
std::unordered_map<std::string, std::vector<VarHandleBase *>> fetched_vars;
std::vector<FetchOpHandle *> fetch_ops;
std::vector<OpHandleBase *> ready_fetch_ops;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some case, the fetch_op are ready at the beginning.

@chengduoZH chengduoZH merged commit 1342e2e into PaddlePaddle:develop Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants