Skip to content

polish deepCF model to support real dataset#16454

Merged
panyx0718 merged 2 commits intoPaddlePaddle:developfrom
panyx0718:imperative2
Mar 27, 2019
Merged

polish deepCF model to support real dataset#16454
panyx0718 merged 2 commits intoPaddlePaddle:developfrom
panyx0718:imperative2

Conversation

@panyx0718
Copy link
Contributor

No description provided.

test=develop
test=develop
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

else:
raise ValueError("Unsupported dtype %s", self._value.dtype)
if self._value.size > 1024 * 1024 * 5:
if self._value.size > 1024 * 1024 * 1024:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumpyArrayInitializer limits numpy size. I think a few GBs is OK

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyx0718 panyx0718 merged commit f8c279b into PaddlePaddle:develop Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants