Closed
Conversation
test=develop
Contributor
|
Does this PR solve #16399 (comment)? |
Contributor
@sfraczek What do you think about this fix? |
Author
|
Sorry, it seems it is not working well in all cases. |
|
Probably one problem is that "mkldnn depthwise conv pass" runs after "conv bn fuse pass" so the depthwise convolutions are not replaced by regular convolution and cannot be fused with batch norm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch sets the mkldnn passes in correct order.
With the previous order the relu op was not fused in ResNet50 model.
test=develop