Fix allreducedep bug#16443
Merged
gongweibao merged 3 commits intoPaddlePaddle:developfrom Mar 26, 2019
Merged
Conversation
test=develop
test=develop
chengduoZH
reviewed
Mar 26, 2019
| auto outputs = op_desc->Outputs(); | ||
| for (auto& o_it : outputs) { | ||
| for (auto& v : o_it.second) { // values | ||
| vars[v] = order; |
Contributor
There was a problem hiding this comment.
Why do you record the gradient but not parameter here? because the gradient's name may be changed after mem_opt.
Contributor
Author
There was a problem hiding this comment.
Use the op_role_var attr
typhoonzero
reviewed
Mar 26, 2019
| const BuildStrategy &build_strategy, | ||
| ir::Graph *graph) | ||
| : member_(new ParallelExecutorPrivate(places)) { | ||
| VLOG(10) << "enter ParallelExecutor"; |
typhoonzero
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error:
Now:
性能对比：