Merged
Conversation
Collaborator
Author
|
nn.py 修改的原因是 matmul 之前调用了expand，沿着batch size 那个轴，shape会从 -1，变成-10，导致matmul检查无法通过，我尝试过修改expand的行为，发现embedding的bp无法通过 matmul_op.cc 的修改是区分compile time 和run time，不检查compile time时候的shape 这些问题我都会在后续shape问题的梳理中，统一梳理和修复 |
chengduoZH
approved these changes
Mar 21, 2019
phlrain
added a commit
to phlrain/Paddle
that referenced
this pull request
Mar 22, 2019
fix matmul shape check
phlrain
added a commit
that referenced
this pull request
Mar 23, 2019
Merge pull request #16347 from phlrain/fix_matmul_check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.