Skip to content

Add channel wise in quant pass.#16341

Merged
wzzju merged 2 commits intoPaddlePaddle:developfrom
wzzju:add_channel_wise_in_quant_pass
Mar 22, 2019
Merged

Add channel wise in quant pass.#16341
wzzju merged 2 commits intoPaddlePaddle:developfrom
wzzju:add_channel_wise_in_quant_pass

Conversation

@wzzju
Copy link
Contributor

@wzzju wzzju commented Mar 21, 2019

No description provided.

@wzzju wzzju requested review from NHZlX and qingqing01 March 21, 2019 04:38
@wzzju wzzju force-pushed the add_channel_wise_in_quant_pass branch from b2bc936 to 8965819 Compare March 21, 2019 04:39
Copy link
Contributor

@NHZlX NHZlX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

void operator()(const platform::CPUDeviceContext& dev_ctx,
const framework::Tensor* in, const framework::Tensor** scales,
const int scale_num, T max_range, framework::Tensor* out) {
if (scale_num == 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some comments in next pr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,Thx.

@wzzju wzzju merged commit ec11135 into PaddlePaddle:develop Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants