Skip to content

Feature/refactor layers to Layers#16337

Merged
JiabinYang merged 9 commits intoPaddlePaddle:developfrom
JiabinYang:feature/add_nce_sequence_conv
Mar 27, 2019
Merged

Feature/refactor layers to Layers#16337
JiabinYang merged 9 commits intoPaddlePaddle:developfrom
JiabinYang:feature/add_nce_sequence_conv

Conversation

@JiabinYang
Copy link
Contributor

add these layers under Layers

  1. nce
  2. PRelu
  3. BilinearTensorProduct
  4. Conv2DTranspose
  5. SequenceConv

add these test under test_layers

  1. nce
  2. PRelu
  3. BilinearTensorProduct
  4. Conv2DTranspose
  5. SequenceConv
  6. Embedding

@JiabinYang JiabinYang requested a review from junjun315 March 22, 2019 05:07
from test_imperative_base import new_program_scope
from paddle.fluid.imperative import nn
from paddle.fluid.imperative import base
import pdb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JiabinYang JiabinYang changed the title Feature/add nce sequence conv Feature/refactor layers to Layers Mar 25, 2019
Copy link
Contributor

@junjun315 junjun315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 0d9d25d into PaddlePaddle:develop Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants