add reduce_all, reduce_any op#16320
Merged
phlrain merged 7 commits intoPaddlePaddle:developfrom Apr 11, 2019
Merged
Conversation
add reduce_all, reduce_any op
Contributor
XiaoguangHu01
left a comment
XiaoguangHu01
left a comment
There was a problem hiding this comment.
- paddle/fluid/operators/reduce_ops/reduce_all_any_op.h
建议分成2个文件，reduce_all_op.h和reduce_any_op.h，文件名更容易理解 - 请添加单元测试
- 文档请 @shanyi15 审核
Collaborator
|
please preview first, thanks! refer to here |
split reduce_all_any_op.h into two files add unit test for reduce_all, reduce_any
Contributor
Author
谢谢，已经做了相应修改。 |
Contributor
Author
|
seems preview doc is really necessary :) |
Collaborator
|
|
Contributor
Author
|
@shanyi15 reduce_all 计算的是tensor 中coefficient 的逻辑与，reduce_any 计算的是tensor 中coefficient的逻辑或。这两个op 的注释与其他reduce 操作的注释保持一致，请参考reduce_max。 |
Collaborator
明白了，看与或非的英文那儿能否写rst语法， |
Contributor
Author
|
👌 |
Contributor
Author
|
|
shanyi15
approved these changes
Apr 1, 2019
XiaoguangHu01
approved these changes
Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #16314