[MKL-DNN] Fix to crash of Transformer when mkldnn is to be used#16233
Merged
luotao1 merged 4 commits intoPaddlePaddle:developfrom Mar 19, 2019
Merged
[MKL-DNN] Fix to crash of Transformer when mkldnn is to be used#16233luotao1 merged 4 commits intoPaddlePaddle:developfrom
luotao1 merged 4 commits intoPaddlePaddle:developfrom
Conversation
Desc: TensorCopy was not setting MKLDNN primitive descriptor when layout was to be kMKLDNN test=develop
Contributor
|
Please add |
test=develo
test=develop
Contributor
Author
|
@luotao1 I have updated changes with your suggestions. |
luotao1
reviewed
Mar 18, 2019
| if (use_mkldnn) { | ||
| cfg.EnableMKLDNN(); | ||
| std::unordered_set<std::string> op_list = {"transpose2"}; | ||
| cfg.SetMKLDNNOp(op_list); |
Contributor
There was a problem hiding this comment.
Why should we specify op_list for transformer ut? Could we remove line192-193?
Contributor
Author
There was a problem hiding this comment.
@luotao1 Good point. Manual selection of mkl-dnn ops for transformer was removed.
jczaja
added a commit
to jczaja/Paddle
that referenced
this pull request
Mar 27, 2019
…ed (PaddlePaddle#16233)" This reverts commit 13816dd. Apart from enabling transformer for MKL-DNN
jczaja
added a commit
to jczaja/Paddle
that referenced
this pull request
Mar 28, 2019
…ed (PaddlePaddle#16233)" This reverts commit 13816dd. Apart from enabling transformer for MKL-DNN
tensor-tang
pushed a commit
that referenced
this pull request
Mar 28, 2019
* Revert "[MKL-DNN] Fix to crash of Transformer when mkldnn is to be used (#16233)" This reverts commit 13816dd. Apart from enabling transformer for MKL-DNN * Revert "- MKL-DNN pooling updated to set_prim_desc" This reverts commit c63f6b2. Conflicts: paddle/fluid/operators/mkldnn/concat_mkldnn_op.cc * Revert "[MKL-DNN] MKL-DNN specific Tensor modification (#15429)" test=develop This reverts commit dec9cf5. * - concat compilation fix - lint test=develop - Lint fixes test=develop - Lint fixes test=develop - Fix Transpose MKLDNN op test=develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing transformer analyzer test when MKL-DNN is to be used. Root cause of crash was that TensorCopy was not setting MKLDNN primitive descriptor when layout was to be kMKLDNN