Skip to content

Make timeline_py compatible#16185

Merged
chengduoZH merged 2 commits intoPaddlePaddle:developfrom
chengduoZH:fix_timeline_py
Mar 14, 2019
Merged

Make timeline_py compatible#16185
chengduoZH merged 2 commits intoPaddlePaddle:developfrom
chengduoZH:fix_timeline_py

Conversation

@chengduoZH
Copy link
Contributor

No description provided.

@chengduoZH chengduoZH requested a review from tensor-tang March 13, 2019 10:27
tensor-tang
tensor-tang previously approved these changes Mar 13, 2019
Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with a legacy profile file, works fine.

@tensor-tang
Copy link
Contributor

Encountered AttributeError: 'Event' object has no attribute 'detail_info' now.
Please fix detail_info as well.

test=develop
Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit 84c0054 into PaddlePaddle:develop Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants