set stop_gradient sign to all loss layers#15955
Closed
velconia wants to merge 2 commits intoPaddlePaddle:developfrom
Closed
set stop_gradient sign to all loss layers#15955velconia wants to merge 2 commits intoPaddlePaddle:developfrom
velconia wants to merge 2 commits intoPaddlePaddle:developfrom
Conversation
test=develop
… add_stop_grad_to_loss_op test=develop
chengduoZH
reviewed
Feb 28, 2019
|
|
||
| helper = LayerHelper('bpr_loss', **locals()) | ||
| out = helper.create_variable_for_type_inference(dtype=input.dtype) | ||
| label.stop_gradient = True |
Contributor
There was a problem hiding this comment.
We shouldn't secretly change the user's configuration.
Collaborator
Author
There was a problem hiding this comment.
This is a hot fix
Contributor
There was a problem hiding this comment.
This is not hot fix. It's introducing new bugs.
Collaborator
Author
There was a problem hiding this comment.
So... what's the best way to solve the problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test=develop