Skip to content

Revert 15770 develop a6910f900 gelu mkl opt#15872

Merged
tensor-tang merged 2 commits intoPaddlePaddle:developfrom
tensor-tang:revert-15770-develop_a6910f900_gelu_mkl_opt
Feb 22, 2019
Merged

Revert 15770 develop a6910f900 gelu mkl opt#15872
tensor-tang merged 2 commits intoPaddlePaddle:developfrom
tensor-tang:revert-15770-develop_a6910f900_gelu_mkl_opt

Conversation

@tensor-tang
Copy link
Contributor

@tensor-tang tensor-tang commented Feb 22, 2019

@yihuaxu since the problem below, we should revert firstly.

CE job failed. http://ce.paddlepaddle.org:8080/viewLog.html?buildId=27374&buildTypeId=PaddleModesl_BuildModels

image

@tensor-tang tensor-tang requested a review from luotao1 February 22, 2019 04:24
@tensor-tang
Copy link
Contributor Author

revert 的code中有改动cmake, 需要 @panyx0718 approve

Step 1/1] + echo 'checking cmake/external change, PR: 15872, changes: cmake/external/mklml.cmake'
[06:28:48][Step 1/1] + '[' cmake/external/mklml.cmake ']'
[06:28:48][Step 1/1] + '[' 15872 '!=' '' ']'
[06:28:48][Step 1/1] checking cmake/external change, PR: 15872, changes: cmake/external/mklml.cmake
[06:28:48][Step 1/1] ++ curl -H 'Authorization: token 95a329e820eeae12c4c5c8a0b6e3e39654dc01a4' 'https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15872/reviews?per_page=10000'
[06:28:48][Step 1/1] ++ python /paddle/tools/check_pr_approval.py 1 2887803
[06:28:48][Step 1/1]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[06:28:48][Step 1/1]                                  Dload  Upload   Total   Spent    Left  Speed
[06:28:49][Step 1/1] 
[06:28:49][Step 1/1]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
[06:28:50][Step 1/1]   0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
[06:28:50][Step 1/1] 100  1770  100  1770    0     0   1151      0  0:00:01  0:00:01 --:--:--  1151
[06:28:50][Step 1/1] current pr 15872 got approvals: FALSE
[06:28:50][Step 1/1] You must have panyx0718 approval for the api change! cmake/external
[06:28:50][Step 1/1] + APPROVALS=FALSE
[06:28:50][Step 1/1] + echo 'current pr 15872 got approvals: FALSE'
[06:28:50][Step 1/1] + '[' FALSE == FALSE ']'
[06:28:50][Step 1/1] + echo 'You must have panyx0718 approval for the api change! cmake/external'
[06:28:50][Step 1/1] + exit 1

@tensor-tang tensor-tang merged commit ee2321d into PaddlePaddle:develop Feb 22, 2019
@tensor-tang tensor-tang deleted the revert-15770-develop_a6910f900_gelu_mkl_opt branch February 22, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants