Skip to content

Add Pixel shuffle OP#15782

Merged
shippingwang merged 29 commits intoPaddlePaddle:developfrom
shippingwang:pixel_shuffle
Apr 3, 2019
Merged

Add Pixel shuffle OP#15782
shippingwang merged 29 commits intoPaddlePaddle:developfrom
shippingwang:pixel_shuffle

Conversation

@shippingwang
Copy link
Member

@shippingwang shippingwang commented Feb 18, 2019

Add pixel shuffle Op.

Pixel shuffle rearranges elements in a tensor of shape [N, C, H, W] to [N, C / r^2, H * r, W * r], which r is an upscale_factor.

NOTE: Pixel shuffle Op. shuffles input data. NOT simple reshaping.

@shippingwang shippingwang changed the title Pixel shuffle Add Pixel shuffle API Feb 21, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give a link here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the -> The

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

@heavengate heavengate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is python API test in test_layers.py needed?

@shippingwang
Copy link
Member Author

Is python API test in test_layers.py needed?

yeah

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem in this API for the variable length input image. H and W is not fixed.

@shanyi15
Copy link
Collaborator

shanyi15 commented Mar 19, 2019

plz preview it first, thanks

@shippingwang
Copy link
Member Author

plz review it first, thanks

OK will add it.

@shippingwang shippingwang changed the title Add Pixel shuffle API Add Pixel shuffle OP Mar 28, 2019
@shippingwang
Copy link
Member Author

image
预览效果updated

qingqing01
qingqing01 previously approved these changes Apr 2, 2019
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shanyi15
Copy link
Collaborator

shanyi15 commented Apr 2, 2019

image

@shippingwang
Copy link
Member Author

image
DONE!

shanyi15
shanyi15 previously approved these changes Apr 2, 2019
Copy link
Collaborator

@shanyi15 shanyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG comments

qingqing01
qingqing01 previously approved these changes Apr 3, 2019
shanyi15
shanyi15 previously approved these changes Apr 3, 2019
@shippingwang shippingwang dismissed stale reviews from shanyi15 and qingqing01 via cddc827 April 3, 2019 08:16
@shippingwang shippingwang merged commit 229dc93 into PaddlePaddle:develop Apr 3, 2019
shippingwang added a commit to shippingwang/Paddle that referenced this pull request Apr 11, 2019
* add pixel_shuffle op

* add pixel_shuffle op, test=develop

* rewrite code, test=develop

* delete useless comment, test=develop

* Refine pixel_shuffle_op and unit testing

* refine code,test=develop

* refine .cu,test=develop

* fix unittest,test=develop

* Fix unit testing
test=develop

* resolve conflict, test=develop

* fix test, test=develop

* fix API, test=develop

* fix test datatype bug,test=develop

* polish comments,test=develop

* add API,test=develop

* test=develop

* Add Pixel_Shuffle OP,test=develop

* support python3,test=develop

* add include memory to travis CI bug,test=develop
shippingwang added a commit that referenced this pull request Apr 12, 2019
* cherry-pick 16763,test=release/1.4

* cherry-pick 16763, test=release/1.4

* fix some comments, include cosine_decay,l2_normalize,pixel_shuffle

* Add api.spec, test=develop

* update api.spec, test=develop

* add api.spec,test=develop

* test=develop

* test=develop

* fix conflict,test=develop

* Add Pixel shuffle OP (#15782)

* add pixel_shuffle op

* add pixel_shuffle op, test=develop

* rewrite code, test=develop

* delete useless comment, test=develop

* Refine pixel_shuffle_op and unit testing

* refine code,test=develop

* refine .cu,test=develop

* fix unittest,test=develop

* Fix unit testing
test=develop

* resolve conflict, test=develop

* fix test, test=develop

* fix API, test=develop

* fix test datatype bug,test=develop

* polish comments,test=develop

* add API,test=develop

* test=develop

* Add Pixel_Shuffle OP,test=develop

* support python3,test=develop

* add include memory to travis CI bug,test=develop

* cherry-pick 16763,15782 , test=release/1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants