Skip to content

[Operator] Add range op.#15431

Merged
wanghaoshuang merged 8 commits intoPaddlePaddle:developfrom
wanghaoshuang:range_op
Mar 22, 2019
Merged

[Operator] Add range op.#15431
wanghaoshuang merged 8 commits intoPaddlePaddle:developfrom
wanghaoshuang:range_op

Conversation

@wanghaoshuang
Copy link
Contributor

@wanghaoshuang wanghaoshuang commented Jan 19, 2019

test=develop
Like arange function of numpy.

test=develop
@wanghaoshuang wanghaoshuang changed the title Add range op. [Operator] Add range op. Jan 19, 2019
"The step of range op should not be 0.");
PADDLE_ENFORCE(((start < end) && (step > 0)) || ((start > end) && (step < 0)),
"The step should be greater than 0 while start < end. And the "
"step should be less than 0 while start > end.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在应该还不支持step<0吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复支持,多谢提醒。

Copy link
Contributor

@jerrywgz jerrywgz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Jan 30, 2019
@shanyi15
Copy link
Collaborator

shanyi15 commented Mar 8, 2019

请及时预览哈,谢谢

qingqing01
qingqing01 previously approved these changes Mar 14, 2019
@wanghaoshuang
Copy link
Contributor Author

image

test=develop
test=develop
@shanyi15
Copy link
Collaborator

plz amplify example

Copy link
Collaborator

@shanyi15 shanyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remember to amplify example later

Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG api.spec

@wanghaoshuang wanghaoshuang merged commit 18779b5 into PaddlePaddle:develop Mar 22, 2019
@wanghaoshuang wanghaoshuang deleted the range_op branch May 20, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants