Closed
Conversation
wangkuiyi
requested changes
Jan 30, 2017
| typedef std::function<void(const VectorPtr vecs[])> ExecFunc; | ||
| void exec(ExecFunc func); | ||
|
|
||
| void resize(int size, |
Collaborator
There was a problem hiding this comment.
这么长的method implementation应该放在.cc文件里，而不是头文件里。
| endif() | ||
|
|
||
| if(USE_CAFFE) | ||
| add_subdirectory(plugin/caffe) |
Collaborator
There was a problem hiding this comment.
为什么不是放在 third_party 目录里，而是放在一个新的 plugin 目录里呢？这个plugin目录将来还会用来放其他一些什么不属于"3rd party"的内容吗？
|
|
||
| /** | ||
| * Get the size of inputLayer[i]. | ||
| */ |
Collaborator
There was a problem hiding this comment.
参数 i 并没有在 getConfig 的实现里被用到？
| # limitations under the License | ||
| # use caffe plugin | ||
|
|
||
| set(CAFFE_PATH $ENV{CAFFE_PATH} CACHE PATH "Folder contains caffe") |
Collaborator
There was a problem hiding this comment.
这里可以假设caffe的源码在某个目录里吗？比如 thrid_party/caffe。如果不存在，则运行 git clone 命令来获取之。要求用户指定一个参数（CAFFE_PATH）意味着需要用户了解更多细节，我感觉这里没有这个必要？
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
* fix train config * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #253
还未完成~
TODO: