Add conv3d/pool3d/conv3d_trans Python API#11437
Merged
chengduoZH merged 5 commits intoPaddlePaddle:developfrom Jun 15, 2018
Merged
Add conv3d/pool3d/conv3d_trans Python API#11437chengduoZH merged 5 commits intoPaddlePaddle:developfrom
chengduoZH merged 5 commits intoPaddlePaddle:developfrom
Conversation
typhoonzero
reviewed
Jun 13, 2018
python/paddle/fluid/layers/nn.py
Outdated
Contributor
There was a problem hiding this comment.
Can use @templatedoc to avoid copying comments, see yu laoshi's PR: #11308
Contributor
Author
There was a problem hiding this comment.
@typhoonzero Sound great!
But Convlution Layer and Convlution Op are not completely equal.
The equation of Convlution Layer is Convlution Op's is
chengduoZH
force-pushed
the
Add_conv3d_Python_API
branch
from
0af11ef to
9b13b4c
Compare
typhoonzero
previously approved these changes
Jun 14, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM++, 2d and 3d layers have a lot common codes, we may need to put them to some base class then.
… Add_conv3d_Python_API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #11433