Merged
Conversation
typhoonzero
reviewed
Jun 11, 2018
| std::string in_var_name = request_->Varname(); | ||
| std::string out_var_name = request_->OutVarname(); | ||
| VLOG(3) << "in_var_name: " << in_var_name | ||
| << " RequestPrefetch: " << out_var_name; |
Contributor
There was a problem hiding this comment.
Log format should like: "RequestPrefetch, in_var_name: " << in_var_name << " out_var_name: " << out_var_name
Contributor
|
Need to fix transpiler tests before merging. |
Yancey0623
reviewed
Jun 12, 2018
| } | ||
| parallel_blkids.push_back(blkid); | ||
| for (size_t i = 1; i < optimize_block_id_list.size(); ++i) { | ||
| // skip the first optimize block because it is already in the |
Contributor
There was a problem hiding this comment.
The comment here is skip the first optimize block..., but still start from i = 1?
Member
Author
There was a problem hiding this comment.
i is the index of optimize_block_id_list, the optimize_block_id_list[0] is 1, so optimize_block_id_list[1] will not be 1.
13 tasks
typhoonzero
reviewed
Jun 12, 2018
| last_parent_blkid = program->Block(blkid).Parent(); | ||
| } | ||
| parallel_blkids.push_back(blkid); | ||
| for (size_t i = 1; i < optimize_block_id_list.size(); ++i) { |
Contributor
There was a problem hiding this comment.
maybe should start from 2? block0 is only listen_and_serv, and block1 is pushed at line 139
Member
Author
There was a problem hiding this comment.
the first(index=0) item in optimize_block_id_list is 1, the second(index=1) will be 2.
typhoonzero
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
project: #10868