Enable CPU on Parallel executor#11306
Merged
chengduoZH merged 13 commits intoPaddlePaddle:developfrom Jun 11, 2018
Merged
Conversation
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
9 times, most recently
from
0ac07d8 to
a4f5fa5
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
7 times, most recently
from
591340e to
f5f039b
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
from
cb99f1b to
2d94697
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
2 times, most recently
from
59681d8 to
61b14f1
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
from
61b14f1 to
495368c
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
3 times, most recently
from
f98634a to
e77874c
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
from
e77874c to
a57e8a4
Compare
luotao1
reviewed
Jun 11, 2018
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
How fluid_benckmark.py benchmark CPU multi-thread training? Would you implement it in next PR?
Contributor
Author
|
@luotao1 Certainly. |
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
3 times, most recently
from
dd8969e to
7289a1a
Compare
chengduoZH
force-pushed
the
enable_cpu_on_pe
branch
from
7289a1a to
7b72383
Compare
reyoung
reviewed
Jun 11, 2018
|
|
||
| if(WITH_GPU) | ||
| nv_library(nccl_all_reduce_op_handle SRCS nccl_all_reduce_op_handle.cc DEPS op_handle_base scope lod_tensor ddim memory | ||
| nv_library(nccl_all_reduce_op_handle SRCS all_reduce_op_handle.cc DEPS op_handle_base scope lod_tensor ddim memory |
Collaborator
There was a problem hiding this comment.
nccl_all_reduce_op_handle --> all_reduce_op_handle ?
…running with CUDA, so use_cuda maybe more intuitive.
reyoung
approved these changes
Jun 11, 2018
Collaborator
reyoung
left a comment
reyoung
left a comment
There was a problem hiding this comment.
Cool
However, MultiCPU version should not broadcast parameters to multi-scopes. Parameter should be shared in global.
Looking forward to next PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CPU on the Parallel executor.