Skip to content

Comments

refine benchmark/fluid#11158

Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom
luotao1:benchmark1
Jun 5, 2018
Merged

refine benchmark/fluid#11158
luotao1 merged 2 commits intoPaddlePaddle:developfrom
luotao1:benchmark1

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jun 4, 2018

  • refine benchmark/.gitigone
  • fix typo of argument learning_rate
  • add argument --cpus for multi-thread cpus
  • use a common function print_train_time to reduce lines
  • mkdir -p logs to store all the logs
  • fix --models=resnet50 to --models=resnet, since the file name resnet.py.
  • fix the issue when running with --gpus > 1, duplicated with Fluid benchmark support recordio reader #11121 (comment)

@luotao1 luotao1 requested a review from typhoonzero June 4, 2018 13:00
type=int,
default=1,
help='If gpus > 1, will use ParallelExecutor to run, else use Executor.')
parser.add_argument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not see changes to deal with --cpus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Remove it and will add in next PR when using ParallelDo to do multi-thread CPU training.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luotao1 luotao1 merged commit f2c5574 into PaddlePaddle:develop Jun 5, 2018
@luotao1 luotao1 deleted the benchmark1 branch June 5, 2018 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants