Withdraw MKLDNN Mul operator#10703
Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom May 31, 2018
Merged
Conversation
Contributor
|
@mozga-intel Where is the (python) transpose matrix? |
Contributor
Author
mozga-intel
force-pushed
the
mozga-intel/Mul_mkldnn_withdraw
branch
2 times, most recently
from
6809be3 to
f92fa2d
Compare
luotao1
previously approved these changes
May 30, 2018
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
LGTM！Could you please merge the latest develop code to pass the teamcity?
mozga-intel
force-pushed
the
mozga-intel/Mul_mkldnn_withdraw
branch
from
f92fa2d to
30d3203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mkldnn mul operator was withdraw because the mul operator + (python) transpose matrix gets worse performance than the version of mklml.