Feature/Inference data flow graph for analysis#10610
Closed
Superjomn wants to merge 15 commits intoPaddlePaddle:developfrom
Closed
Feature/Inference data flow graph for analysis#10610Superjomn wants to merge 15 commits intoPaddlePaddle:developfrom
Superjomn wants to merge 15 commits intoPaddlePaddle:developfrom
Conversation
panyx0718
reviewed
May 13, 2018
Contributor
panyx0718
left a comment
panyx0718
left a comment
There was a problem hiding this comment.
This PR doesn't seem to have any meaningful test in it? not sure how is this related to tensorrt integration...
| std::pair< | ||
| std::vector<Node *>, | ||
| std::vector< | ||
| Node *>> static ExtractInputAndOutputOfSubGraph(std::vector<Node *> |
Contributor
There was a problem hiding this comment.
format this line better?
| // using NodesBFSIterator = xxx | ||
|
|
||
| // NodesBFSIterator nodes_begin(); | ||
| // NodesBFSIterator nodes_end(); |
| * iterate in a graph defined Inverse order. | ||
| */ | ||
| template <typename GraphType> | ||
| struct Inverse { |
Contributor
There was a problem hiding this comment.
Is this used? If not, delete it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10611
This is a part of the large PR #10459
It is based on the PR #10522 and should not merge before that PR.