[Test-deiven] Understand Sentiment: start testing understand_sentiment#10539
Closed
[Test-deiven] Understand Sentiment: start testing understand_sentiment#10539
Conversation
jetfuel
requested review from
JiayiFeng,
abhinavarora,
daming-lu,
helinwang,
jacquesqiao,
reyoung,
sidgoyal78 and
wangkuiyi
… testDrivenUnderstandSentiment
sidgoyal78
reviewed
May 21, 2018
Contributor
sidgoyal78
left a comment
sidgoyal78
left a comment
There was a problem hiding this comment.
@jetfuel : Actually there were a couple of changes to the API, and both @daming-lu and I decided that we will create a new PR #10812
Do you think we can close this PR?
Contributor
Author
|
@sidgoyal78 Of course, feel free to close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update syntax to fit the latest fluid