Clean OpProtoAndCheckerMaker #10486
Merged
Clean OpProtoAndCheckerMaker #10486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use ctor * Reduce line of codes. * We can use virtual function for Maker now. * The implementation does not care what maker holds, it is easier to refactor later.
reyoung
force-pushed
the
feature/clean_op_maker
branch
from
095fd3b to
0e78cb6
Compare
reyoung
commented
May 11, 2018
|
|
||
| virtual ~OpProtoAndCheckerMaker() { | ||
| PADDLE_ENFORCE(validated_, "should call Validate after build"); | ||
| CHECK(validated_) << "should call Validate after build"; |
Collaborator
Author
There was a problem hiding this comment.
Exception in desturctor will only crash and cannot be catched. Change here to CHECK
reyoung
commented
May 11, 2018
|
|
||
| void SetProto(proto::OpProto *proto) { proto_ = proto; } | ||
|
|
||
| void SetChecker(OpAttrChecker *attr_checker) { op_checker_ = attr_checker; } |
Collaborator
Author
There was a problem hiding this comment.
Do not use constructor to avoid all inherited classes to have a constructor.
dzhwinter
approved these changes
May 11, 2018
Contributor
dzhwinter
left a comment
dzhwinter
left a comment
There was a problem hiding this comment.
This replacement looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use ctor
refactor later.