Merged
Conversation
Contributor
|
@dzhwinter Should this also be done in |
Contributor
Author
|
That's true. Done. |
abhinavarora
approved these changes
May 4, 2018
sidgoyal78
approved these changes
May 4, 2018
Contributor
sidgoyal78
left a comment
sidgoyal78
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR Zhihong.
sidgoyal78
reviewed
May 6, 2018
Contributor
sidgoyal78
left a comment
sidgoyal78
left a comment
There was a problem hiding this comment.
@dzhwinter : It seems that changing the datatype to float64, we get an error:
paddle.fluid.core.EnforceNotMet: Tensor holds the wrong type, it holds f at [/paddle/paddle/fluid/framework/tensor_impl.h:84]
Did I miss something?
Contributor
Author
|
@sidgoyal78 also need to change the optimizer datatype. |
Contributor
|
@dzhwinter Do you have an example? I don't quite understand how we could change the optimizer datatype. (Since, in the optimizer API we don't have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #10405