Skip to content

Do we need public method Flush() for BlockDescBind and OpDescBind? #6543

@helinwang

Description

@helinwang

Flush() will be call automatically when calling Proto(), why do we still need it as a public method? For simplicity I think we need to change Flush() to private or just remove it (put into Proto()).

Currently they two are only called in these two places publicly:

./framework/program_desc.cc:31:    block->Flush();
./framework/block_desc.cc:104:    op_desc->Flush();

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions