[XPU] support xpu mask adaptive output without embedding; test=develop#9970
Merged
zhupengyang merged 1 commit intoPaddlePaddle:developfrom Feb 28, 2023
Merged
[XPU] support xpu mask adaptive output without embedding; test=develop#9970zhupengyang merged 1 commit intoPaddlePaddle:developfrom
zhupengyang merged 1 commit intoPaddlePaddle:developfrom
Conversation
newway
requested review from
hong19860320,
mjp9527 and
zhupengyang
as code owners
|
Thanks for your contribution! |
newway
force-pushed
the
vsl_v3
branch
2 times, most recently
from
d73ea5e to
e4363e0
Compare
zhupengyang
reviewed
Feb 27, 2023
zhupengyang
approved these changes
Feb 28, 2023
Comment on lines
+27
to
+31
| if (input_shape.size() == 2) { | ||
| // need to insert an sequence_unpad op to enable some vsl pass | ||
| // the output shape of sequence_unpad is 2dims | ||
| param_.input->Resize({1ULL, input_shape[0], input_shape[1]}); | ||
| } |
Collaborator
There was a problem hiding this comment.
修改input shape的做法是很trick的。如果有需求，应该在pass中增加reshape op
newway
added a commit
to newway/Paddle-Lite
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR devices
PR types
PR changes
Description