Skip to content

[arm] fix invalid read error#7709

Merged
chenjiaoAngel merged 5 commits intoPaddlePaddle:developfrom
chenjiaoAngel:read_invalid
Dec 6, 2021
Merged

[arm] fix invalid read error#7709
chenjiaoAngel merged 5 commits intoPaddlePaddle:developfrom
chenjiaoAngel:read_invalid

Conversation

@chenjiaoAngel
Copy link
Collaborator

No description provided.

@paddle-bot-old
Copy link

Thanks for your contribution!

bias_value[1] = bias[ci * 4 + 1];
bias_value[2] = bias[ci * 4 + 2];
bias_value[3] = bias[ci * 4 + 3];
if (ci * 4 + 4 < chout) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加上这些 if 后,会不会影响性能?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会的,但是没有这个判断,会有读越界风险。在精度和性能上只能选择精度

Copy link
Collaborator

@zhaoyang-star zhaoyang-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiaoAngel chenjiaoAngel merged commit 4abd1d5 into PaddlePaddle:develop Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants