Skip to content

update slice and reshape op and test on one op fake model test=develop#2377

Merged
jiweibo merged 1 commit into
PaddlePaddle:developfrom
jiweibo:op_update
Nov 6, 2019
Merged

update slice and reshape op and test on one op fake model test=develop#2377
jiweibo merged 1 commit into
PaddlePaddle:developfrom
jiweibo:op_update

Conversation

@jiweibo

@jiweibo jiweibo commented Nov 6, 2019

Copy link
Copy Markdown
Collaborator

update reshape op to support multiple input types of shape.
priority: input(ShapeTensor) > input(Shape) > attr(shape)

tested on the following three models:

  1. attr(shape)

image

2. input(Shape)

image

3. input(ShapeTensor)

image

update slice op to support multiple iput types of starts and ends.
priority: input(StartsTensor) > input(StartsTensorList) > attr(starts)

tested on the following three models:

  1. attr(starts)

image

2. input(StartsTensorList)

image

3. input(StartsTensor)

image

@jiweibo jiweibo requested a review from FrostML November 6, 2019 06:09

@FrostML FrostML left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto ret =
std::find(decrease_axis.begin(), decrease_axis.end(), axes[i]);
if (ret != decrease_axis.end()) {
ends[i] = 10000000;

@Shixiaowei02 Shixiaowei02 Nov 6, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fluid 原始代码中这个地方用 std::numeric_limits<int32_t>::max() 好一些

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到,下次更新的时候改掉

@jiweibo jiweibo merged commit e74609b into PaddlePaddle:develop Nov 6, 2019
@jiweibo jiweibo deleted the op_update branch November 6, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants