[TSP] last_norm allgather move to model.py #5911
Merged
+29
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
yuanlehome
reviewed
Jan 7, 2026
Comment on lines
592
to
597
| out = self.norm(hidden_states, residual, forward_meta=forward_meta)[0] | ||
| hidden_states = hidden_states + residual | ||
|
|
||
| if self.norm.is_last_norm and self.norm.fd_config.parallel_config.use_sequence_parallel_moe: | ||
| hidden_states = self.norm.allgather(hidden_states, forward_meta.ids_remove_padding.shape[0]) | ||
|
|
||
| out = self.norm(hidden_states, forward_meta=forward_meta)[0] |
yuanlehome
reviewed
Jan 7, 2026
Comment on lines
452
to
460
| if self.norm.is_last_norm and self.norm.fd_config.parallel_config.use_sequence_parallel_moe: | ||
| out = self.norm.allgather(out, forward_meta.ids_remove_padding.shape[0]) | ||
|
|
||
| return out | ||
|
|
||
| if current_platform.is_iluvatar() and forward_meta.attn_backend.mixed: | ||
| out = forward_meta.attn_backend.reverse_transpose(out) | ||
|
|
||
| return out |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/online/20251131 #5911 +/- ##
==========================================================
Coverage ? 58.46%
==========================================================
Files ? 320
Lines ? 39195
Branches ? 5916
==========================================================
Hits ? 22916
Misses ? 14436
Partials ? 1843
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuanlehome
changed the title
yuanlehome
merged commit 799bb56
into
PaddlePaddle:release/online/20251131
12 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
开启SP时，LLM主模型的last norm和gather过程耦合在一起，不便于多步投机解码调用。故将此特殊的norm和gather进行解耦。
Modifications
修改各个moe模型的组网，在组网中将其解耦。
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.