[Model] add tracking trail on vis_mot #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChaoII <849453582@qq.com>
Signed-off-by: ChaoII <849453582@qq.com>
Signed-off-by: ChaoII <849453582@qq.com>
Signed-off-by: ChaoII <849453582@qq.com>
jiangjiajun
requested changes
Nov 2, 2022
| def vis_mot(im_data, mot_result, score_threshold=0.0, is_draw_trail=False, trails: dict = None): | ||
| if is_draw_trail: | ||
| if trails is None: | ||
| print("[WARNING] <trails> must be a global dict, when <is_draw_trail> is True ,trails will be hidden!") |
| cv::waitKey(30); | ||
| frame_id++; | ||
| } | ||
| capture.release(); |
Collaborator
There was a problem hiding this comment.
在for循环后，显式调用一行model.UnBindRecorder(); 便于用户直接了解
| cv2.waitKey(30) | ||
| if cv2.waitKey(30) == ord("q"): | ||
| break | ||
| cap.release() |
Collaborator
There was a problem hiding this comment.
也显式调用一行model.unbind_trail_recorder()
| class FASTDEPLOY_DECL PPTracking: public FastDeployModel { | ||
| inline void TrailRecorder::Add(int id, const | ||
| std::vector<std::array<int, 2>> &record) { | ||
| records[id] = record; |
Collaborator
There was a problem hiding this comment.
这里逻辑跟之前的不同
之前是遍历每个boxes，然后同时从map中查找到id，往id对应的vec push数据，现在是直接赋值，是一样的吗？
| void BindRecorder(TrailRecorder* recorder); | ||
| /** \brief cancel binding and clear trail information | ||
| */ | ||
| void UnBindRecorder(); |
Collaborator
There was a problem hiding this comment.
Unbind是一个单词，驼峰时给单词首字母大写即可，这里改成UnbindRecorder()
| from .... import c_lib_wrap as C | ||
|
|
||
|
|
||
| class TrailRecorder(C.vision.tracking.TrailRecorder): |
Collaborator
There was a problem hiding this comment.
不要使用这种继承的方式，这样会导致FastDeploy在编译时，如果没有ENABLE_VISION的情况下，在import fastdeploy时，会提示找不到C.vision
| from __future__ import absolute_import | ||
| from .... import FastDeployModel, ModelFormat | ||
| from .... import c_lib_wrap as C | ||
|
|
Collaborator
There was a problem hiding this comment.
可以改成
try:
TrailRecorder = C.TrailRecorder
except:
pass
这样在python层面可以直接用fastdeploy.vision.tracking.TrailRecorder 无需再创建一个类
jiangjiajun
requested changes
Nov 2, 2022
| TrailRecorder = C.vision.tracking.TrailRecorder | ||
| except Exception as e: | ||
| logging.warning("something was wrong, detail:" + str(e) + | ||
| "so 'TrailRecorder' can not be loaded") |
Collaborator
There was a problem hiding this comment.
这行提示不用打出来，就单纯pass即可，否则在没有ENABLE_VISION的时候，import fastdeploy会打出来上面这行提示
Collaborator
|
有个代码冲突需解决下 |
jiangjiajun
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types(PR类型)
Model
Describe
效果如下：