Skip to content

Conversation

@fnavigate84
Copy link
Contributor

PR types(PR类型)

Description

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2022

CLA assistant check
All committers have signed the CLA.

@fnavigate84 fnavigate84 force-pushed the develop branch 5 times, most recently from 2674c4d to 062d284 Compare December 30, 2022 03:29
# include_directories(${SOPHGONPU_RUNTIME_PATH}/${SOPHGO_TARGET}/include)
#else ()
# message(FATAL_ERROR "[SOPHGO.cmake] download_and_decompress SOPHGO_runtime error")
#endif ()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释的debug代码需要删除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经去掉注释

# SOPHGO部署库编译

## C++ SDK编译安装
SOPHGO支持linux下进行编译,系统为Debian/Ubuntu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python不能支持么?

@@ -0,0 +1,61 @@
# paddleclas C++部署示例
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaddleClas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

@@ -0,0 +1,35 @@
Global:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个yaml文件跟模型里面自带的inference_cls.yaml是重复的么,是否可以移除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经移除

@@ -0,0 +1,47 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件在README.md中没提到怎么使用

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件没有用,已经移除了

@@ -0,0 +1,47 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@@ -0,0 +1,43 @@
# SOPHGO部署库编译
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档需同时在docs/en/build_and_install提供英文版本

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经添加英文版本。

#include <vector>

namespace fastdeploy {
struct SophgoBackendOption{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有任何配置参数吗?

<< model_file << std::endl;
return false;
}
}else if (model_format == ModelFormat::SOPHGO) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

花括号后需要空格

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已加

valid_ipu_backends = {Backend::PDINFER};
} else {
}else if (model_format == ModelFormat::SOPHGO) {
valid_cpu_backends = {Backend::SOPHGONPU2};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOPHOGONPU2还支持CPU吗? 另外这个后面加的2是表示2代吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里写的有问题,已经做了修改。

@fnavigate84 fnavigate84 force-pushed the develop branch 2 times, most recently from c907187 to 99fcb86 Compare January 3, 2023 09:18
@jiangjiajun jiangjiajun changed the title add sophgo backend [Backend] add sophgo backend Jan 4, 2023
# 添加FastDeploy库依赖
message(STATUS @@)
message(STATUS ${FASTDEPLOY_LIBS})
target_link_libraries(infer_demo ${FASTDEPLOY_LIBS})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17-18行不需要

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

install(PROGRAMS ${PADDLELITE_LIBS} DESTINATION lib)

file(GLOB TIMVX_LIBS ${FASTDEPLOY_INSTALL_DIR}/third_libs/install/paddlelite/lib/verisilicon_timvx/*)
install(PROGRAMS ${TIMVX_LIBS} DESTINATION lib)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20~39行与sophgo也无关系,可以移除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经删除

@@ -0,0 +1,75 @@
# PaddleDetection SOPHGO部署示例
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个标题需要修改,当前目录为YOLOv5

install(PROGRAMS ${PADDLELITE_LIBS} DESTINATION lib)

file(GLOB TIMVX_LIBS ${FASTDEPLOY_INSTALL_DIR}/third_libs/install/paddlelite/lib/verisilicon_timvx/*)
install(PROGRAMS ${TIMVX_LIBS} DESTINATION lib)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同Clas中的CMAKE,移除不必要的代码

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

@@ -0,0 +1,56 @@
# PaddleDetection C++部署示例
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

install(PROGRAMS ${PADDLELITE_LIBS} DESTINATION lib)

file(GLOB TIMVX_LIBS ${FASTDEPLOY_INSTALL_DIR}/third_libs/install/paddlelite/lib/verisilicon_timvx/*)
install(PROGRAMS ${TIMVX_LIBS} DESTINATION lib)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同前面的CMAKE问题

@@ -0,0 +1,277 @@
#include "fastdeploy/backends/sophgo/sophgo_backend.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参照其它代码添加copyright在代码开头

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经添加

@jiangjiajun jiangjiajun merged commit 34bea76 into PaddlePaddle:develop Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants