Skip to content

hotfix/get rid of inflect dependency and refactoring robustness #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 1, 2023
Merged

hotfix/get rid of inflect dependency and refactoring robustness #478

merged 10 commits into from
Jun 1, 2023

Conversation

@RakshitKhajuria
Copy link
Contributor

@RakshitKhajuria RakshitKhajuria commented May 31, 2023 •
edited
Loading

Checklist:

  • I've removed inflect dependecy
  • I've updated number to word class.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@RakshitKhajuria RakshitKhajuria changed the title hotfix/470 get rid of inflect dependencies hotfix/470 get rid of inflect dependency May 31, 2023
@RakshitKhajuria RakshitKhajuria requested review from ArshaanNazir and chakravarthik27 and removed request for ArshaanNazir May 31, 2023 11:07
chakravarthik27
chakravarthik27 reviewed May 31, 2023
View reviewed changes
nlptest/transform/robustness.py

return ''.join(results), trans

for idx, sample in enumerate(sample_list):
Copy link
Collaborator

@chakravarthik27 chakravarthik27 May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't refactor this section, this will handle when list of samples or strings in the function.

@RakshitKhajuria RakshitKhajuria changed the title hotfix/470 get rid of inflect dependency hotfix/get rid of inflect dependency and refactoring robustness May 31, 2023
@RakshitKhajuria RakshitKhajuria self-assigned this May 31, 2023
@RakshitKhajuria RakshitKhajuria linked an issue May 31, 2023 that may be closed by this pull request
get rid of some dependencies #470
Closed
@ArshaanNazir ArshaanNazir merged commit 102795a into release/1.4.0 Jun 1, 2023
@RakshitKhajuria RakshitKhajuria deleted the 470-get-rid-of-inflect-dependencies branch June 1, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chakravarthik27 chakravarthik27 chakravarthik27 approved these changes

Assignees

@RakshitKhajuria RakshitKhajuria

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get rid of some dependencies

4 participants

@RakshitKhajuria @chakravarthik27 @ArshaanNazir