Skip to content

chore: project quality improvements + CI/CD#9

Merged
PaSympa merged 9 commits intomainfrom
feature/project-quality
Mar 25, 2026
Merged

chore: project quality improvements + CI/CD#9
PaSympa merged 9 commits intomainfrom
feature/project-quality

Conversation

@PaSympa
Copy link
Copy Markdown
Owner

@PaSympa PaSympa commented Mar 25, 2026

Summary

Project quality audit and improvements:

  • fix: Server version now read dynamically from package.json (was hardcoded 1.0.0)
  • refactor: Improved type safety — replaced 3 as any casts with proper discord.js types
  • chore: Added engines field (node >=18) and .env.example
  • chore: Dockerfile now runs as non-root user with OCI labels
  • chore: Added declarationMap and sourceMap to tsconfig
  • docs: Added CHANGELOG.md, CONTRIBUTING.md, SECURITY.md
  • refactor: Extracted magic numbers to shared src/constants.ts
  • ci: Added GitHub Actions — CI build check on PR + automated release on tag push (npm, Docker, GitHub release)
  • docs: Updated README project structure

GitHub Secrets Required for CI/CD

After merge, add these secrets in repo Settings > Secrets:

  • NPM_TOKEN — npm access token (with publish permission)
  • DOCKERHUB_USERNAME — Docker Hub username
  • DOCKERHUB_TOKEN — Docker Hub access token

Test plan

  • Build passes
  • Server reports correct dynamic version (v1.4.0)
  • All 90 tools tested on live Discord server
  • Docker builds successfully with non-root user

PaSympa added 9 commits March 25, 2026 15:47
Use NewsChannel for addFollower, GuildScheduledEventCreateOptions
and GuildScheduledEventEditOptions for scheduled events.
Keep guarded as-any for discord.js channel mixins (invites, webhooks).
CI runs on push/PR to main (build check).
Release triggers on tag push (v*): publishes to npm,
builds and pushes Docker image, creates GitHub release.

Requires secrets: NPM_TOKEN, DOCKERHUB_USERNAME, DOCKERHUB_TOKEN.
@PaSympa PaSympa merged commit 07d54ce into main Mar 25, 2026
1 check passed
@PaSympa PaSympa deleted the feature/project-quality branch March 25, 2026 15:29
@PaSympa PaSympa mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant