Skip to content

[backport] macos ci fixes for v1.16#25672

Merged
dakejahl merged 3 commits intorelease/1.16from
mrpollo/116_macos_ci
Sep 30, 2025
Merged

[backport] macos ci fixes for v1.16#25672
dakejahl merged 3 commits intorelease/1.16from
mrpollo/116_macos_ci

Conversation

@mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Sep 29, 2025

locks down gcc v9 and brings a fix for macos sitl

mrpollo and others added 2 commits September 29, 2025 08:41
This is a compiler-specific extension
@mrpollo mrpollo force-pushed the mrpollo/116_macos_ci branch 2 times, most recently from aa0ab94 to 38d05f8 Compare September 29, 2025 15:58
@dakejahl
Copy link
Contributor

Is this ready @mrpollo ?

@mrpollo
Copy link
Contributor Author

mrpollo commented Sep 30, 2025

Not yet, I'm debugging, the issue is the GitHub runners updated the LLVM version, there are fixes in main to address this, and I'm trying to minimize how much of it we bring to this branch for fixes, I'm experimenting a few things I'll be done by EOD

Signed-off-by: Ramon Roche <[email protected]>
@mrpollo mrpollo force-pushed the mrpollo/116_macos_ci branch from aa8220f to 312f873 Compare September 30, 2025 21:25
@mrpollo
Copy link
Contributor Author

mrpollo commented Sep 30, 2025

@dakejahl As soon as CI passes this will can merged I have confirmed it working here https://github.com/PX4/PX4-Autopilot/actions/runs/18143473441?pr=25672

@dakejahl dakejahl merged commit ac5ed50 into release/1.16 Sep 30, 2025
65 checks passed
@dakejahl dakejahl deleted the mrpollo/116_macos_ci branch September 30, 2025 21:49
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-dev-call-oct-1-2025-team-sync-and-community-q-a/47561/1

@farhangnaderi farhangnaderi moved this from Todo to Done in PX4 v1.17 Release Oct 10, 2025
Spir0u pushed a commit to aithon-robotics/PX4-Autopilot that referenced this pull request Jan 26, 2026
* ci: lockdown gcc v9 for macos

Signed-off-by: Ramon Roche <[email protected]>

* pxh: do not use variable sized array on the stack

This is a compiler-specific extension

* ci: macos build on older gcc

Signed-off-by: Ramon Roche <[email protected]>

---------

Signed-off-by: Ramon Roche <[email protected]>
Co-authored-by: Beat Küng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants