Update px4-rc.gzsim. Fix gz_world checking for PX4_GZ_STANDALONE=1#25346
Merged
dakejahl merged 1 commit intoPX4:release/1.16from Aug 1, 2025
Merged
Update px4-rc.gzsim. Fix gz_world checking for PX4_GZ_STANDALONE=1#25346dakejahl merged 1 commit intoPX4:release/1.16from
dakejahl merged 1 commit intoPX4:release/1.16from
Conversation
…de. Priority of gz_world (really running) over PX4_GZ_WORLD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update px4-rc.gzsim. Fix gz_world checking for PX4_GZ_STANDALONE=1 mode. Priority of gz_world (really running) over PX4_GZ_WORLD
Solved Problem
Currently in PX4_GZ_STANDALONE=1 mode script uses PX4_GZ_WORLD as true and does not see what world is really runned. It leads to needing to adding PX4_GZ_WORLD=${PX4_GZ_WORLD:=default} with correct world name you planed to run. It is ok for NOT STANDALONE mode. But in STANDALONE it leads to double place for world configuring (airframe and same world in gazebo launcher). And you cant use any other world in Gazebo launcher (only same as in airframe).
I belive in PX4_GZ_STANDALONE script should attach to any really runned world (as it was in PX4 v1.14 ).
I fix that with using really runned world attach to.