Fix issue where XRCE_DDS Bridge did not respect environment variables

[sansha]

Solved Problem

Fixes #25188 (detailed description in that issue)

Solution

Hi, this is the PR fixing #25188 by removing the -h 127.0.0.1 flag in the launch command for the client.
This fix works for me, not sure if other setups are affected.

Let me know your thoughts!

Changelog Entry

For release notes:

Feature/Bugfix Fix bug where UXRCE_DDS_AG_IP was not read when launching the xrce client in SITL.

Alternatives

In the first commit I load the env variable explicitly but changed this to just remove the flag since I cannot test this right now. But this of course would also be an option

Test coverage

• Unit/integration test: ...
• Simulation/hardware testing logs: https://review.px4.io/

Context

Related links, screenshot before/after, video

[beniaminopozzan]

thanks @sansha , could you set the default value for the IP address in simulation to 127.0.0.1 to maintain back-compatibility?

[sansha]

thanks @sansha , could you set the default value for the IP address in simulation to 127.0.0.1 to maintain back-compatibility?

Hey, not sure what you mean. I can set the default to 127.0.0.1 (see 59a751d) but the problem I had was in simulation, so I would like to also change it in simulation. Maybe outside of sim we want to keep it to 127.0.0.1?

[beniaminopozzan]

@sansha , outside the sim, when you set UXRCE_DDS_CFG=Ethernet, it uses whaterver value you set for UXRCE_DDS_AG_IP.
As the most common case in sim is ip set to 127.0.0.1 my request is to keep the defaul IP for sim / posix target to 127.0.0.1.

So, please make the default value for UXRCE_DDS_AG_IP equal to 127.0.0.1 (2130706433) in sim, thanks!

[sansha]

@beniaminopozzan thank you for the feedback and apologies for taking so long. I added setting a default value earlier in the script. Is this what you intended?
Thank you!

Do you think this fix can make it into 1.16.0? Would be amazing to have this in and being able move to a stable version.

[sansha]

CI Failing with MAVROS Mission Tests is not related I think, will try resolving by merging main.

Unable to find image 'px4io/px4-dev-ros-melodic:2021-09-08' locally
docker: Error response from daemon: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit.
See 'docker run --help'.

[beniaminopozzan]

Thanks @sansha !

[beniaminopozzan]

@sansha yes, it can go in 1.16!

Could you open a backport pr on the release/1.16 brach cherry picking the merged commit please? Thanks!

[sansha]

@beniaminopozzan awesome, I opened a backport PR here: #25299
Thanks!