Correct units of CRSF GPS altitude

[n-snyder]

Solved Problem

When sending CRSF telemetry, the GPS message provided an incorrect value for altitude [m]. This is because the existing PX4 code assumed the altitude_msl_m in the SensorGPS uORB message was in units of mm, instead of m.

Solution

Removed scaling of the altitude in the uORB message by 1000.

Changelog Entry

Bugfix for CRSF GPS telemetry

Test coverage

Tested with ELRS transmitter in the loop to confirm correct values.

[bresch]

was it wrong before f000238#diff-befa46f2bd4efc7a67651a054834b31a6eee6aa04341559f93dd36b164087d82L248 then?

[bresch]

I think the reported altitude should be in mm, not meters. Did you test the changes? Setting the altitude in meters + 1000 doesn't make sense, the +1000 are in millimeters

Looks like you were right!

[n-snyder]

Cool! Thanks @bresch for looking into this.